Conversation
And similarly for br_on_cast_desc and br_on_cast_desc_fail. This anticipates a future where we may want a ref.cast_desc instruction that performs a normal cast rather than just comparing descriptor pointers, but takes a descriptor as a handle to the target RTT to use for the cast.
rossberg
approved these changes
Jan 29, 2026
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Jan 29, 2026
And similar for br_on_cast_desc and br_on_cast_desc_fail. This matches a rename happening upstream in the proposal repo: WebAssembly/custom-descriptors#89 Change-Id: I4d13b719b9c2acff7bcbe56aab7ef52f8c066dc7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7529922 Auto-Submit: Thomas Lively <tlively@google.com> Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#104985}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And similarly for br_on_cast_desc and br_on_cast_desc_fail. This
anticipates a future where we may want a ref.cast_desc instruction that
performs a normal cast rather than just comparing descriptor pointers,
but takes a descriptor as a handle to the target RTT to use for the
cast.