Conversation
Update wasm-module-builder.js with the new custom descriptors functionality that has been added to the V8 version of the file, then use it to test that installing prototypes on descriptors works as intended.
Member
Author
|
@rmahdav PTAL as well! |
rossberg
approved these changes
Nov 4, 2025
Comment on lines
+853
to
+856
| is_final = fields.is_final ?? fields.final ?? false; | ||
| supertype_idx = MustBeNumber( | ||
| fields.supertype_idx ?? fields.supertype ?? kNoSuperType, | ||
| "supertype"); |
Member
There was a problem hiding this comment.
I don't understand the duplication here. Why are there two ways to pass these arguments?
Member
Author
There was a problem hiding this comment.
Using an option bag is convenient for building types with lots of things going on such as descriptors, describees, etc. The non-option-bag interface is kept for compatibility with existing tests, but doesn't support new features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update wasm-module-builder.js with the new custom descriptors
functionality that has been added to the V8 version of the file, then
use it to test that installing prototypes on descriptors works as
intended.