-
Notifications
You must be signed in to change notification settings - Fork 249
feat: connect-sign #2307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: connect-sign #2307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty. Also added authorized and authorizing for connector events.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository |
tanguyenvn
reviewed
Dec 9, 2025
|
|
||
| export const CONNECTOR_INITIAL_AUTHENTICATION_MODE = { | ||
| CONNECT_ONLY: "connect-only", | ||
| CONNECT_AND_SIGN: "connect-and-sign", |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use snake case
Suggested change
| CONNECT_AND_SIGN: "connect-and-sign", | |
| CONNECT_AND_SIGN: "connect_and_sign", |
chaitanyapotti
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
In this PR, We Introduced
connect-sign&connect-onlyUX, adds a circular loader with connector-specific color, and enhances connector authorization flow and events. UpdatesIWeb3AuthCoreOptionsto supportinitialAuthenticationModeand addsauthorized / authorizingconnector events. Refreshes hooks for isAuthorized and updates multiple connectors (EVM, Solana, WC v2, Coinbase, MetaMask). Demo and i18n strings updated.Figma Link: https://www.figma.com/design/YkID6Vr1OVMevKawLiCYM1/Demo?node-id=4495-995&m=dev
Description
Web3AuthInnerContextto surfaceauthorizationstate.modalManagertweaks for new flows and event emits.IWeb3AuthCoreOptionswithinitialAuthenticationMode(connect-sign&connect-only).isAuthorizedstatus.EVM, MetaMask, Coinbase, WalletConnect v2.How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: