Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing channels #24

Open
wants to merge 9 commits into
base: latest
Choose a base branch
from

Conversation

jbcpollak
Copy link

On our private instance we discovered that some channels were missing when we used /list-private.

After digging in I found that the groups api was deprecated in favor of conversations. I fixed it to make it work, but for my own familiarity I bumped the node dependency version up to 10.x and used async/await. I hope that’s ok, or at least this can be a template for fixing the problem as you desire.

@shushugah
Copy link

this is great, also bumping the node version, so that other people can clone this more confidently

@aredridel
Copy link
Contributor

This looks good as far as what's changed — did you spend any time looking at other things affected by the slack module upgrade?

@jbcpollak
Copy link
Author

did you spend any time looking at other things affected by the slack module upgrade?

I didn't specifically review API changes but I do know we ran / are running this modification in production on our local slack with no issues. I'm no longer at the company but as of December 2019 we had no issues with the bot with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants