Plugin Runner: Schema validation for findings #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the start of validating the details of plugin results. - Plugin type is now passed to the wrapper. - Linter now relies on validating against a JSON schema. While the output isn't as user-friendly, it'll be easier to maintain long-term since we may be able to sync it with the API spec. - Initial validation for static_analysis findings.
mdfleury-wbd
approved these changes
Dec 18, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds schema validation for the
detailsfield of plugin results.The validation is now specified using JSON schemas. The results are somewhat less user-friendly, but in the future we may be able to sync it with the API spec.
Only the three finding types which are documented in plugins/README.md are included:
As we fill-out our documentation of the plugin types, we will update the schemas as well.
Example output:
Motivation and Context
Enable debugging of plugin issues with the format of the findings which have caused runtime issues.
How Has This Been Tested?
Tested locally.
Types of changes
Checklist