Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pyright to dev deps #337

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Add Pyright to dev deps #337

merged 1 commit into from
Oct 28, 2024

Conversation

ZoogieZork
Copy link
Contributor

@ZoogieZork ZoogieZork commented Oct 28, 2024

Description

Adds Pyright to the dev dependencies in the Pipfiles.

Note

This only adds the "pyright" command-line tool. Normally in VSCode, Pyright inherits its configuration from Pylance, so to get the same results on the command-line we will need to update pyproject.toml to match the settings. That effort is still a work-in-progress, so this PR just adds Pyright to the deps for now.

Motivation and Context

Allows us to run Pyright from the command-line and ensure that we don't have any dependency conflicts.

How Has This Been Tested?

Tested running Pyright locally, e.g.:

cd backend/engine
pyright .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This is so we can run Pyright from the command-line.
@ZoogieZork ZoogieZork marked this pull request as ready for review October 28, 2024 20:11
@ZoogieZork ZoogieZork requested a review from a team as a code owner October 28, 2024 20:11
@ZoogieZork ZoogieZork added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit cd0a77b Oct 28, 2024
6 checks passed
@ZoogieZork ZoogieZork deleted the zoogiezork/pipfile-pyright branch October 28, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants