Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Datadog configurations for Artemis #248

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Add Datadog configurations for Artemis #248

merged 3 commits into from
Aug 26, 2024

Conversation

Kamsiy
Copy link
Contributor

@Kamsiy Kamsiy commented Aug 26, 2024 •
edited
Loading

Description

Add terraform configurations to enable datadog in Artemis lambdas

Motivation and Context

How Has This Been Tested?

tested in a dev environment

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Pic

Embed something funny here

@Kamsiy Kamsiy marked this pull request as ready for review August 26, 2024 15:40
@Kamsiy Kamsiy requested a review from a team as a code owner August 26, 2024 15:40
@Kamsiy Kamsiy requested a review from mdfleury-wbd August 26, 2024 16:10
mdfleury-wbd
mdfleury-wbd approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@mdfleury-wbd mdfleury-wbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Kamsiy Kamsiy added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit ea0d30c Aug 26, 2024
6 checks passed
@Kamsiy Kamsiy deleted the datadog-artemis2 branch August 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdfleury-wbd mdfleury-wbd mdfleury-wbd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kamsiy @mdfleury-wbd