Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Repo Healthcheck 1.0.0 #220

Merged
merged 7 commits into from
Jul 30, 2024
Merged

Github Repo Healthcheck 1.0.0 #220

merged 7 commits into from
Jul 30, 2024

Conversation

g-marconet
Copy link
Contributor

Merging Github Repo Healthcheck 1.0.0 feature branch into main. Nothing in this PR is new

Description

All changes are from:

In short, adds:

  • Branch rules
  • Composite rules
    • So that configs can allow repos to pass with either branch protection rules or branch rules for a particular rule

Breaking change - This renames the branch protection rules from branch_* to branch_protection_*, and so will require changes to configs.

Motivation and Context

  • These changes enable configs to be constucted such that their rules pass for repos with either branch protection rules or branch rules

How Has This Been Tested?

  • Tests pass
  • Working in dev environment

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist

  • My code follows conforms to the coding standards.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@g-marconet g-marconet requested a review from a team as a code owner July 29, 2024 20:51
@g-marconet g-marconet marked this pull request as draft July 29, 2024 21:12
@g-marconet g-marconet marked this pull request as ready for review July 29, 2024 21:16
ZoogieZork
ZoogieZork previously approved these changes Jul 30, 2024
@g-marconet g-marconet added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit e29c633 Jul 30, 2024
5 checks passed
@g-marconet g-marconet deleted the g-marconet/ghrc-1.0.0 branch July 30, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants