NOT READY: Fix scroll animation on main page #161
Conversation
JekiXD
left a comment
JekiXD
left a comment
There was a problem hiding this comment.
Don't you think that the scroll logic is a bit too complicated? The camera position and other related stuff could just be interpolated using splines, without gsap
|
@JekiXD, answer on your question (#161 (review)): GSAP do almost all animations transitions related to frontend. This lib do automatic animation interpolation and sync all elements transitions while scroll and state change. It will be hard to replace it's behavior with own manual solution. This will take too much time and all animations must be changed from zero. This isn't correct solution. |
| fn clamp_canvas_size( canvas : &HtmlCanvasElement ) | ||
| { | ||
| let aspect = canvas.client_width() as f32 / canvas.client_height() as f32; | ||
|
|
||
| if canvas.width() > 1920 || canvas.height() > 1080 | ||
| { | ||
| canvas.set_width( ( 1080.0 * aspect ) as u32 ); | ||
| canvas.set_height( 1080 ); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This can make our rendering look bad if user has high resolution screen like 2k or 4k. I think its better to let user decide, for example we can add a check box "Fast performance" and if user clicks it then we decrease resolution
Goal: fix scroll animation on main page
Description: This PR fixes issues related to scroll GSAP animations on main page
What changed: