Open
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Wan Team!
Recently, I use flash-attention-3 to accelerate inference, but I meet the error below:
Obviously, it's an attention error. I check the attention code in
wan/modules/attention.py, and find a controversial code:I check the source code of flash-attention-3, the function
flash_attn_interface.flash_attn_varlen_func()only returntupleunder the following condition:return_softmaxonly works under the following condition:However, these two parameters
return_softmaxanddropout_pare not included in your code.So, we only need
flash_attn_interface.flash_attn_varlen_func()returnout, which is atorch.Tensor.It works for me.