Fixed an issue with unsafe dimension expansion when handling 1D timestep tensors#218
Open
thkkk wants to merge 1 commit intoWan-Video:mainfrom
Open
Fixed an issue with unsafe dimension expansion when handling 1D timestep tensors#218thkkk wants to merge 1 commit intoWan-Video:mainfrom
thkkk wants to merge 1 commit intoWan-Video:mainfrom
Conversation
expand()only works on dimensions of size 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added view(-1, 1) before expanding 1D tensors:
The original code attempted to directly expand 1D tensors to 2D, which could cause runtime errors since expand() only works on dimensions of size 1 (or just keep the size of dimensions). The fix ensures we first reshape 1D tensors to have a size-1 dimension before expansion.
Moreover: