-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: show discover api #1542
Draft
devceline
wants to merge
12
commits into
main
Choose a base branch
from
discover-api-hooks-w3i
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore: show discover api #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris13524
reviewed
Apr 23, 2024
chris13524
reviewed
Apr 23, 2024
chris13524
reviewed
Apr 23, 2024
chris13524
reviewed
Apr 23, 2024
chris13524
reviewed
Apr 23, 2024
Co-authored-by: Chris Smith <[email protected]>
chris13524
reviewed
May 7, 2024
chris13524
reviewed
May 7, 2024
Co-authored-by: Chris Smith <[email protected]>
chris13524
reviewed
May 7, 2024
chris13524
reviewed
May 7, 2024
glitch-txs
approved these changes
May 18, 2024
chris13524
approved these changes
May 20, 2024
can we merge? @devceline @chris13524 |
@glitch-txs no this API is not implemented yet and is here for "docs first" purposes. @devceline can you make draft? |
glitch-txs
suggested changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure changed under AppKit/WalletKit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Show to potentially use discover api
https://walletconnect-docs-git-discover-api-hooks-w3i-walletconnect1.vercel.app/web3inbox/frontend-integration/api#discover-apps-to-subscribe-to