Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFSM #293

Open
wants to merge 19 commits into
base: ct-opt
Choose a base branch
from
Open

DFSM #293

wants to merge 19 commits into from

Conversation

AthulKrishnaSundarrajan
Copy link
Contributor

Purpose

Adding in DFSM functionality into WEIS.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

@dzalkind
Copy link
Collaborator

dzalkind commented Jul 2, 2024

Hi Athul,

Thanks for adding this. It looks great so far. Do you need to merge in the latest ctopt? There seem to be a lot of extra changes besides the DFSM stuff. It's possible that the ctopt branch is also behind where you started this. We can discuss tomorrow.

dzalkind
dzalkind reviewed Jul 2, 2024
View reviewed changes
examples/19_DFSM/README.md Outdated

Checkout `run_simulation.py` on how to use the DFSM with ROSCO for closed-loop simulation.

The DFSM is available in the `dfsm_1p6.pkl` file. This model has been specifically built for simulating load cases from DLC 1.6.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we generate this pickle file? What's in the pickle file? Can it be expressed in a readable way?

dzalkind
dzalkind reviewed Jul 2, 2024
View reviewed changes
weis/dfsm/inputs/example_schema.yaml Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add this?

@ptrbortolotti
Copy link
Collaborator

818Nawaf is now blocked for the WISDEM organization. this account is likely a bot and had already been blocked for IEA Wind Task 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzalkind dzalkind dzalkind left review comments

@818Nawaf 818Nawaf 818Nawaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AthulKrishnaSundarrajan @dzalkind @ptrbortolotti @818Nawaf