Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 130 collection hybrid changes #130

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

badeshiben
Copy link

@badeshiben badeshiben commented Mar 31, 2020

I integrated the distributed and hybrid changes into collection cost. Fixed a few bugs I found, too.
I integrated hybrid changes into site preparation cost.

@akey7 akey7 requested review from akey7, eberlea and parangat94 April 1, 2020 20:41
@akey7
Copy link
Contributor

akey7 commented Apr 1, 2020

@badeshiben @eberlea I recommend we set this review aside until the other collection cost changes are resolved

Copy link
Contributor

@akey7 akey7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badeshiben go ahead and make the changes we discussed in the meeting around putting if statements for reading project data and the project list from the input data. Then I will re-review!

…ulates the collection system length in manual mode, which is also equal to the base road length and is used in erection for crane travel distances. XlsxReader now reads in turbine spacings for auto mode, and the collection_layout input sheet for manual mode.
@badeshiben
Copy link
Author

@akey7 @parangat94
Added the layout_length method to CostModule (parent class for modules) as Alicia and I discussed this morning. This method is called in SitePrep and Erection. This eliminates the interdependencies between modules. I've checked outputs to see if they make sense. Still needs review, of course!

@badeshiben
Copy link
Author

I should add that project_list.xlsx has a new entry: "Collection mode". This flag specifies the collection mode. "manual" or "auto".

@parangat94
Copy link
Contributor

@badeshiben would you set up a quick 30 min meeting to demonstrate this once you're back?

With LandBOSSE now extended to (small) DW, we can start to circle back to this PR. Holding off on reviewing this until after that meeting.

Please feel free to invite @akey7 and @barker59 to this meeting (both optional) as well.

@akey7
Copy link
Contributor

akey7 commented May 27, 2020

@parangat94 @badeshiben Let me know if/when you need my help.

@parangat94 parangat94 changed the base branch from master to pip_installable February 11, 2021 21:45
@parangat94
Copy link
Contributor

parangat94 commented Feb 26, 2021

okay, @badeshiben i think best path is still this:

Branch off of pip_installable (it is up to date with branch master):

  1. Create a separate branch for each file that needs edits. Ideally 1 functionality and 1 file per PR.
  2. Request merging each of these branches into branch pip_installable (PRs)
  3. Request me as a reviewer of all the PRs (additionally, include @akey7 as a reviewer for the erectioncost.py)

@parangat94 parangat94 removed their assignment Feb 26, 2021
@gbarter gbarter changed the base branch from pip_installable to develop June 19, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants