-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 130 collection hybrid changes #130
base: develop
Are you sure you want to change the base?
Conversation
@badeshiben @eberlea I recommend we set this review aside until the other collection cost changes are resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@badeshiben go ahead and make the changes we discussed in the meeting around putting if statements for reading project data and the project list from the input data. Then I will re-review!
…ulates the collection system length in manual mode, which is also equal to the base road length and is used in erection for crane travel distances. XlsxReader now reads in turbine spacings for auto mode, and the collection_layout input sheet for manual mode.
@akey7 @parangat94 |
I should add that project_list.xlsx has a new entry: "Collection mode". This flag specifies the collection mode. "manual" or "auto". |
@badeshiben would you set up a quick 30 min meeting to demonstrate this once you're back? With LandBOSSE now extended to (small) DW, we can start to circle back to this PR. Holding off on reviewing this until after that meeting. Please feel free to invite @akey7 and @barker59 to this meeting (both optional) as well. |
@parangat94 @badeshiben Let me know if/when you need my help. |
okay, @badeshiben i think best path is still this: Branch off of pip_installable (it is up to date with branch master):
|
I integrated the distributed and hybrid changes into collection cost. Fixed a few bugs I found, too.
I integrated hybrid changes into site preparation cost.