Adjust callback function invocation. #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unforunately this isn't purely editorial, because in the process of adjusting the use of "invoke" a number of other things needed to be clarified. Namely: * the operation map now holds JS function objects (i.e., anything with [[Call]]) * these function objects are converted to a specific IDL types only when they are about to be invoked * the select URL algorithm reacts to the promise rather than expecting its value (or rejection reason) to be immediately available Part of whatwg/webidl#1425.
|
@pythagoraskitty ptal? I think this is what is intended here (modulo some other things that remain a little unclear but aren't directly blocking the invoke change). |
16 tasks
xyaoinum
reviewed
Aug 14, 2024
xyaoinum
approved these changes
Aug 14, 2024
|
When this is ready in your opinion, I think one of you will need to merge it, as I don't have write access to this repository. |
github-actions bot
added a commit
that referenced
this pull request
Aug 16, 2024
SHA: ea25980 Reason: push, by xyaoinum Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unforunately this isn't purely editorial, because in the process of adjusting the use of "invoke" a number of other things needed to be clarified.
Namely:
Part of whatwg/webidl#1425.
Preview | Diff