Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the background fetch is aborted, use https://streams.spec.whatwg.org/#readablestream-cancel instead of https://streams.spec.whatwg.org/#readablestream-error for upload streams. #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

When the background fetch is aborted, use https://streams.spec.whatwg.org/#readablestream-cancel instead of https://streams.spec.whatwg.org/#readablestream-error for upload streams. #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ dictionary BackgroundFetchOptions : BackgroundFetchUIOptions {
1. If |stream| has [=ReadableStream/errored=], then set |requestReadFailed| to true.

Note: This ensures we have a copy of the request bytes before resolving.
1. [=If aborted=] and |stream| is [=ReadableStream/readable=], then [=ReadableStream/error=] |stream| with an {{AbortError}} {{DOMException}} and abort these steps.
1. [=If aborted=] and |stream| is [=ReadableStream/readable=], then [=ReadableStream/cancel=] |stream| with an {{AbortError}} {{DOMException}} and abort these steps.
1. Increment |uploadTotal| by |request|'s [=request/body=]'s [=body/length=].
1. Decrement |requestBodiesRemaining| by 1.
1. If at any point storing |requests| fails due to exceeding a quota limit, [=reject=] |promise| with a {{QuotaExceededError}} {{DOMException}} and abort these steps.
Expand Down