-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bikeshed errors in fetch callbacks #164
base: main
Are you sure you want to change the base?
Conversation
@annevk I don't have a good solution for |
1. [=/Fetch=] |request| with the following arguments: | ||
<dl class="compact"> | ||
: [=fetch/useParallelQueue=] | ||
:: True. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annevk I know the fetch spec says I shouldn't need this, but my intent is to be able to do this processing without any page open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tricky aspect is how we enforce any of the things that Fetch requires a client for, such as referrer and CSP. It seems you would have to obtain these ahead of time and pass them in somehow, but there's no infrastructure for that as of yet.
:: The following steps given |chunkLength| (a number): | ||
1. Increment |bgFetch|'s [=background fetch/uploaded=] by |chunkLength|. | ||
1. [=Update background fetch instances=] for |bgFetch|. | ||
: [=fetch/processResponse=] | ||
:: The following steps given |response| (a [=/response=]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are pretty much just re-indentings of the previous algorithm.
With current implementations, once you have seen a response the request has been transmitted. You could wait for processRequestEndOfBody as well I suppose? |
No description provided.