Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a big pile of linking errors. #163

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Fix a big pile of linking errors. #163

merged 2 commits into from
Nov 25, 2021

Conversation

miketaylr
Copy link
Contributor

@miketaylr miketaylr commented Oct 18, 2021 •
edited by pr-preview bot
Loading

Though not all. See #162 for the remaining ones.

Preview | Diff

@miketaylr
Fix a big pile of linking errors.
09e8c80 
Though not all. See WICG#162 for the remaining ones.
@miketaylr
Copy link
Contributor Author

PTAL @beverloo (twitter tells me jake is on PTO!)

annevk
annevk reviewed Oct 19, 2021
View reviewed changes
@miketaylr @annevk
Apply @annevk's suggestions.
3bb1699 
Co-authored-by: Anne van Kesteren <[email protected]>
@miketaylr
Copy link
Contributor Author

PTAL @beverloo @jakearchibald, thanks!

jakearchibald
jakearchibald approved these changes Nov 25, 2021
View reviewed changes
Copy link
Collaborator

@jakearchibald jakearchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll take a look at the rest

@jakearchibald jakearchibald merged commit a1f0bc2 into WICG:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@jakearchibald jakearchibald jakearchibald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miketaylr @jakearchibald @annevk