Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set image pull policy, pull secret and security context on LTPA Job #565

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Set image pull policy, pull secret and security context on LTPA Job #565

merged 2 commits into from
Oct 30, 2023

Conversation

leochr
Copy link
Member

@leochr leochr commented Oct 30, 2023 •
edited
Loading

  • Set image pull policy, pull secret and security context on LTPA Job
  • Update getting-started sample application image

Related to #530

@leochr leochr requested a review from kabicin October 30, 2023 14:26
@leochr
Copy link
Member Author

leochr commented Oct 30, 2023

@kabicin This should cover the basic scenarios (golden-path). I've opened the following issues for edge cases:
#568
#569

kabicin
kabicin approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@kabicin kabicin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leochr leochr merged commit c95e030 into main Oct 30, 2023
@leochr leochr deleted the lcj-ltpa branch October 30, 2023 15:32
This was referenced Nov 7, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabicin kabicin kabicin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leochr @kabicin