Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Update getMessageCount listAction JMSSampleP2P.java #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swarnaditya
Copy link

I have added a some code in JMSSampleP2P.java to get how many messages are on the queue.
Added a listAction=getMessageCount

I have added a some code in JMSSampleP2P.java to get how many messages are on the queue.
Added a listAction=getMessageCount
@swarnaditya swarnaditya reopened this Oct 27, 2021
@scottkurz
Copy link
Member

Hi @swarnaditya ..thank you for your interest and for the PR.

Before even getting to the technical contents, I'm realizing we don't have any guidance listed for contributing. I know it's a small change, but I will look into this first. I understand we can enable a DCO for this repo, in which case you'd just have to do a git commit --signoff on your commit.

Will take a look when I get a chance.

@@ -14,23 +14,28 @@
* THE SAMPLE SOURCE CODE. IBM HAS NO OBLIGATION TO PROVIDE MAINTENANCE, SUPPORT,
* UPDATES, ENHANCEMENTS OR MODIFICATIONS TO THE SAMPLE SOURCE CODE.
*
* (C) Copyright IBM Corp. 2001, 2013.
* (C) Copyright IBM Corp. 2001, 2021.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could change this to:

  • (C) Copyright IBM Corp. and others 2001, 2021.

I'm not a lawyer but I think this would be the typical way for you to "share" the copyright.

@scottkurz
Copy link
Member

scottkurz commented Nov 1, 2021

@swarnaditya - Update: We have added the DCO instructions: https://github.com/WASdev/sample.jms.server/#contributor-license-agreement

So you can update your Git config (if necessary) and do the commit with -s or --signoff option.

Thanks again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants