Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally based on #42
One monolithic commit as this is a mock-up
Notable changes needed to make this work:
Simplifies logic and allows subsequent non cached
find_entry_paths
to overwrite any set aliases(Not actually strictly needed?)It is, if cachedNo it's not, that entry alias would be unsetfind
finds a duplicate entry that's of lower priority than one found during a full search, the higher priority entry is skippedNevertheless, I will create a separate pull request with only this change later
find_entry_paths
call and$FALLBACK_ENTRY_IDS
was moved insidefind_entry
The function needs to see the masked
find
function set insidefind_cached_entry
, and the variable needs to be reset between callsThere's actually no need for it to be a global any more
I don't know if I like
source
ing the cache file, might change that toread
loop when cleaning up, if you're happy with the implementation