Fixed tab triggering browser tab in emscripten/web.

VitalAudio · Feb 5, 2025 · d09f1be · d09f1be
1 parent 29e6495
commit d09f1be
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/visage_widgets/text_editor.cpp b/visage_widgets/text_editor.cpp
@@ -581,6 +581,10 @@ namespace visage {
     return key.modifierMask() == 0 || key.modifierMask() == kModifierShift;
   }
 
+  bool TextEditor::keyRelease(const KeyEvent& key) {
+    return active_;
+  }
+
   String TextEditor::translateDeadKeyText(const String& text) const {
     if (text.length() != 1 || dead_key_entry_ == DeadKey::None)
       return text;

diff --git a/visage_widgets/text_editor.h b/visage_widgets/text_editor.h
@@ -118,6 +118,7 @@ namespace visage {
     void tripleClick(const MouseEvent& e);
     bool handleDeadKey(const KeyEvent& key);
     bool keyPress(const KeyEvent& key) override;
+    bool keyRelease(const KeyEvent& key) override;
     bool receivesTextInput() override { return active_; }
     String translateDeadKeyText(const String& text) const;
     void textInput(const std::string& text) override;
@@ -224,6 +225,7 @@ namespace visage {
     void setBackgroundColorId(int color_id) { background_color_id_ = color_id; }
 
   private:
+    bool processKeyPress(const KeyEvent& key);
     void addUndoPosition() { undo_history_.emplace_back(text_.text(), caret_position_); }
 
     CallbackList<void()> on_text_change_;

diff --git a/visage_windowing/emscripten/windowing_emscripten.cpp b/visage_windowing/emscripten/windowing_emscripten.cpp
@@ -567,11 +567,13 @@ namespace visage {
         return false;
 
       bool down_used = window->handleKeyDown(code, modifier_state, event->repeat);
-      return modifier_state != 0 && modifier_state != kModifierShift && down_used;
+      bool text_input = modifier_state == 0 || modifier_state == kModifierShift;
+      return (code == KeyCode::Tab || !text_input) && down_used;
     }
     case EMSCRIPTEN_EVENT_KEYUP: {
       bool up_used = window->handleKeyUp(code, modifier_state);
-      return modifier_state != 0 && modifier_state != kModifierShift && up_used;
+      bool text_input = modifier_state == 0 || modifier_state == kModifierShift;
+      return (code == KeyCode::Tab || !text_input) && up_used;
     }
     default: return false;
     }