Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect vsi recipes in the Dockerfile and automatically build them #92

Closed
scott-vsi opened this issue Nov 5, 2018 · 1 comment
Closed

Comments

@scott-vsi
Copy link
Contributor

Detect vsi recipes being used in the Dockerfile and automatically build them. A problem I have run into is forgetting to add the recipe to the just build line. While the recipe works the first time, because it is downloaded from dockerhub, subsequent updates to the recipe are not automatically picked up (e.g., an updated pipenv recipe).

@andyneff andyneff transferred this issue from VisionSystemsInc/just Nov 13, 2018
@scott-vsi
Copy link
Contributor Author

The alternative is to prefix the recipe with the PROJECT_NAME. That way, it will fail the first time, and you will be reminded (if a little obliquely) that you need to add recipe to the justify line.

This can be combined with #97 to detect this error from the output of docker-compose to clarify the error in a user friendly way.

@andyneff andyneff added this to the just 0.1.2 milestone May 15, 2019
andyneff added a commit that referenced this issue May 15, 2019
@andyneff andyneff modified the milestones: just 0.2.1, just 0.2.0 Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants