Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: scott-vsi <[email protected]>
  • Loading branch information
andyneff and scott-vsi authored Dec 9, 2024
1 parent eaf8ea2 commit 54f6a18
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ services:
image: ${VSI_COMMON_DOCKER_REPO}:os_${VSI_COMMON_TEST_OS_TAG_NAME-debian_8}
volumes:
- <<: *vsi_common_volume
# Since some of the integration tests bind test dirs in, make sure the
# tmp it is using is the same tmp dir
# Because some of the integration tests bind mount test dirs into the
# container, ensure the tmp dir it is using is the same tmp dir
- type: bind
source: /tmp
target: /tmp
Expand Down
5 changes: 2 additions & 3 deletions linux/just_files/new_just
Original file line number Diff line number Diff line change
Expand Up @@ -716,9 +716,8 @@ function write_dockerfile()
#T# # Modern pyproject.toml packages shouldn'"'"'t require this, but older setup.py projects
#T# # might have an "build requirment" just to start the build process. Common examples
#T# # of this include numpy and torch. E.g. to install numpy before a package builds,
#T# # add numpy to the pre-install line above to install the correct version of numpy
#T# # like this:
#T# # of this include numpy and torch. E.g. to install the correct version of numpy
#T# # before a package builds, add it to the pre-install line above like this
#T# # pip-8210 install pip-tools numpy; \
pip-sync -v /src/requirements.txt; \
Expand Down

0 comments on commit 54f6a18

Please sign in to comment.