Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add signup page #90

Closed
wants to merge 3 commits into from
Closed

Conversation

Ryadav0654
Copy link

fixes: #85

  • Created a new Signup component with a form for user registration.
  • Styled the form using Material-UI and tailwind css

Screenshot

signUp.page.mp4

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dentclack ❌ Failed (Inspect) Oct 4, 2024 0:54am

@Ryadav0654
Copy link
Author

Hi @Vin-Jex,

I’ve created this pull request with the following updates:

  • Added a signup page with responsiveness and support for both dark and light themes.

If anything needs to be changed or improved on the signup page, please let me know. I’m happy to make adjustments based on your feedback!
Could you please review the changes when you have time? Your feedback would be greatly appreciated!

Thanks!

@Vin-Jex
Copy link
Owner

Vin-Jex commented Oct 3, 2024

Hi @Vin-Jex,

I’ve created this pull request with the following updates:

  • Added a signup page with responsiveness and support for both dark and light themes.

If anything needs to be changed or improved on the signup page, please let me know. I’m happy to make adjustments based on your feedback! Could you please review the changes when you have time? Your feedback would be greatly appreciated!

Thanks!

Here’s a rephrased and more structured version that communicates the feedback clearly and professionally:


Hi @Ryadav0654

Thank you for your contribution! I’ve reviewed your pull request, and I appreciate the work you’ve done so far. Here’s some feedback on the signup page:

  1. Keep Your Branch Updated
    Before proceeding, please ensure that your branch is up-to-date with the main branch.

  2. Signup Page Feedback

    • Left Content Layout: The content on the left should fill the entire width and height. Currently, there’s space around the layout, which shouldn’t be the case. Ensure both the left and right sections are fully stretched to the edges.
    • Left Navigation: Don’t worry about the left navigation for now. Just place a div with a background color that fills the entire width of the left section.
    • Right Content Responsiveness: The right content needs to be fully responsive. When the screen size reduces, the two columns in the first row of the form should stack into two rows with one column each.
  3. Dark Mode Background
    When toggling to dark mode, the background color should be #212423. If you need any specific tools or information, feel free to ask, and I’ll provide you with what’s needed.

Let me know if you have any questions or need further clarification. I’m happy to assist!

@Vin-Jex
Copy link
Owner

Vin-Jex commented Oct 4, 2024

@Ryadav0654

Please resolve this issue quick else I would close this PR and make the issue opened for grab again.

IMG_2886

@Ryadav0654
Copy link
Author

Ryadav0654 commented Oct 4, 2024

Ok, I am working.

@Ryadav0654
Copy link
Author

Hi @Vin-Jex ,

I've addressed all the issues and applied the necessary styling changes. Please review the latest updates and let me know if you have any further suggestions or improvements.

Thanks!
Screenshot 2024-10-04 182151

@Vin-Jex
Copy link
Owner

Vin-Jex commented Oct 7, 2024

Firsly, you failed to fix the bug I raised previously and lastly, this branch now has a merge conflict. So resolve the bug, update you branch and fix merge conflict. Thank you!

Copy link

vercel bot commented Oct 7, 2024

@Ryadav0654 is attempting to deploy a commit to the VinJex Team on Vercel.

A member of the Team first needs to authorize it.

@Ryadav0654 Ryadav0654 closed this by deleting the head repository Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Authentication Page ( Sign Up )
2 participants