feat: allow dynamic config of terminationGracePeriodSeconds to work with storage.vminsertConnsShutdownDuration flag #1147
+16
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith storage.vminsertConnsShutdownDuration flag
rl0nergan
requested review from
f41gh7,
Haleygo and
AndrewChubatiuk
as code owners
rl0nergan
force-pushed
the
feat/dynamic-grace-period
branch
from
28e16da
to
70226ac
Compare
f41gh7
reviewed
Nov 6, 2024
| @@ -252,7 +252,7 @@ func performRollingUpdateOnSts(ctx context.Context, podMustRecreate bool, rclien | |||
| for _, pod := range podsForUpdate { | |||
| l.Info("updating pod", "pod", pod.Name) | |||
| // we have to delete pod and wait for it readiness | |||
| err := rclient.Delete(ctx, &pod, &client.DeleteOptions{GracePeriodSeconds: ptr.To(int64(30))}) | |||
| err := rclient.Delete(ctx, &pod, &client.DeleteOptions{GracePeriodSeconds: terminationGracePeriodSeconds}) | |||
There was a problem hiding this comment.
I think it's better to remove client.DeleteOptions from rclient.Delete args.
According to the documentation, it's only required to be set if lower period compared to the value defined at pod level is needed.
It should solve an issue with ignored terminationGracePeriodSeconds for all statefulset components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #744
Currently with larger vmclusters that may need more time to handle vmstorage rollouts, there's a
storage.vminsertConnsShutdownDurationflag we can use to handle gracefully closing connections to vminsert while it rolls out. However the issue we're running into is that the operator uses a hard-coded value of 30s to set the grace period for delete, so we increasing the value used for thestorage.vminsertConnsShutdownDurationflag doesn't help since vmstorage pods will always be killed after 30 seconds.