Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove serviceAccountName from Deployment and StatefulSet, when it's disabled #1684

Merged
merged 1 commit into from
Nov 5, 2024
Merged

remove serviceAccountName from Deployment and StatefulSet, when it's disabled #1684

merged 1 commit into from
Nov 5, 2024

Conversation

AndrewChubatiuk
Copy link
Contributor

fixes #1683

@github-actions github-actions bot added agent vmagent helm chart related issue alert vmalert helm chart related issue auth vmauth helm chart related issue cluster vmcluster helm chart related issue operator operator helm chart related issue single VictoriaMetrics Single node helm chart related issue labels Nov 5, 2024
@AndrewChubatiuk AndrewChubatiuk merged commit 9559f33 into master Nov 5, 2024
26 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the fixed-optional-service-account branch November 5, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekker6 zekker6 zekker6 approved these changes

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

@f41gh7 f41gh7 Awaiting requested review from f41gh7 f41gh7 is a code owner

Assignees
No one assigned
Labels
agent vmagent helm chart related issue alert vmalert helm chart related issue auth vmauth helm chart related issue cluster vmcluster helm chart related issue operator operator helm chart related issue single VictoriaMetrics Single node helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Chart still tries to use SA even when create set to false
2 participants
@AndrewChubatiuk @zekker6