Release workflow #21
Merged
Release workflow #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 16 is EOL
Automatically publish releases to NPM and Docker Hub from GHA. Only performs a release, when: - all tests pass on all supported platforms - a new git tag is pushed (expected format "v1.0.0") - git tag matches the version in package.json The gating of releases happens in the 'check-release' job, which all future release-* jobs depend on. This is where any final linting or sanity checking can be done.
|
Oops, I also updated the Docker image to use node 20 and added a matrix test to cover commonly used node versions. |
jonsmock
force-pushed
the
release-workflow
branch
from
441fcd9
to
4addfc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will automatically do NPM and Docker Hub releases, when we push a git tag of the form 'vX.Y.Z'. Before we release, we run all tests and verify the git tag matches our package.json.
The "release-(npm|docker-hub)" jobs are gated by a "check-release" job, which is where we sanity test the package.json version and could do other linting/checks in the future.
I've added the necessary secrets to this repo. I've verified the tag check works and that the release jobs can work. Other than updating a couple docker actions's versions to remove the GHA node 16 warning, I believe the only thing I haven't tested is the actual publishing of artifacts (commented out in the last commit).
If this looks good, I'll remove the last commit, merge, and push a commit+tag to release 0.4.0 w/ CHANGELOG updates.