Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure exit code regression #18

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix failure exit code regression #18

merged 1 commit into from
Oct 11, 2024

Conversation

jonsmock
Copy link
Collaborator

@jonsmock jonsmock commented Oct 11, 2024

dctest should exit 1 if any test fails. Change the final assertion in
core.cljs to be a positive one: unless we see a :passed result, exit 1.
This should make it more difficult to introduce this kind of bug while
refactoring in the future.

We didn't catch this regression in GHA, because we were swallowing all
exit codes and only checking the results file counts.

Move integration test running into ./test/runexamples, so we can test
all examples locally more easily. Add exit code checking. Also support
running all examples with nbb as well as with a built image.

@jonsmock jonsmock requested review from kanaka and gdw2 October 11, 2024 19:03
dctest should exit 1 if any test fails. Change the final assertion in
core.cljs to be a positive one:  unless we see a :passed result, exit 1.
This should make it more difficult to introduce this kind of bug while
refactoring in the future.

We didn't catch this regression in GHA, because we were swallowing all
exit codes and only checking the results file counts.

Move integration test running into ./test/runexamples, so we can test
all examples locally more easily.  Add exit code checking.  Also support
running all examples with nbb as well as with a built image.
Copy link
Collaborator

@kanaka kanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh, nobody has properly solved the CI runs the same locally as in the cloud problem yet. Either something like nektos/act, or some way for test scripts to output metadata so that GHA can pick up the step definitions from the test scripts (matrix strategy works at the job level, but we need something like that and more powerful at the step level too).

@jonsmock jonsmock merged commit fbd5f90 into main Oct 11, 2024
6 checks passed
@jonsmock jonsmock deleted the fix-exit-code branch October 11, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants