Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lock very_good_cli version in workflow #101

Closed
wants to merge 4 commits into from
Closed

feat: lock very_good_cli version in workflow #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62d9e91
chore: lock very_good_cli version in workflow
Kirpal Feb 10, 2023
cbe8b4a
Apply suggestions from code review
felangel Feb 21, 2023
992fc9f
make default version empty
Kirpal Feb 22, 2023
925782b
Merge branch 'chore/lock-cli-version' of github.com:Kirpal/very_good_…
Kirpal Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/flutter_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ on:
required: false
type: boolean
default: false
very_good_cli_version:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on #90 (comment) about not tightly coupling the public API of the workflow to very_good_cli since very_good_cli is just an implementation detail imo. I think we should instead just restrict the workflow to a specific version range dart pub global activate very_good_cli <0.2.0

required: false
type: string
default: ""
working_directory:
required: false
type: string
Expand Down Expand Up @@ -70,7 +74,7 @@ jobs:

- name: 📦 Install Dependencies
run: |
flutter pub global activate very_good_cli
flutter pub global activate very_good_cli ${{inputs.very_good_cli_version}}
very_good --analytics false
very_good packages get --recursive

Expand Down
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,12 @@ The Flutter package workflow consists of the following steps:

**Default** `""`

#### `very_good_cli_version`

**Optional** The version of [very_good_cli][very_good_cli_link] to use.

**Default** `""`

#### `working_directory`

**Optional** The path to the root of the Flutter package.
Expand Down Expand Up @@ -381,6 +387,7 @@ jobs:
[license_link]: https://opensource.org/licenses/MIT
[logo_black]: https://raw.githubusercontent.com/VGVentures/very_good_brand/main/styles/README/vgv_logo_black.png#gh-light-mode-only
[logo_white]: https://raw.githubusercontent.com/VGVentures/very_good_brand/main/styles/README/vgv_logo_white.png#gh-dark-mode-only
[very_good_cli_link]: https://pub.dev/packages/very_good_cli
[very_good_ventures_link_dark]: https://verygood.ventures#gh-dark-mode-only
[very_good_ventures_link_light]: https://verygood.ventures#gh-light-mode-only
[very_good_ventures_link]: https://verygood.ventures
Expand Down