chore: optimize Request.read

VeryGoodOpenSource · Jun 22, 2024 · 45f32ab · 45f32ab
1 parent aa6b818
commit 45f32ab
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/packages/dart_frog/CHANGELOG.md b/packages/dart_frog/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 1.1.1-wip
+
+- chore: optimize `Request.read()`.
+
 # 1.1.0
 
 - feat: support reuse of nested router ([#393](https://github.com/VeryGoodOpenSource/dart_frog/pull/393))

diff --git a/packages/dart_frog/lib/src/request.dart b/packages/dart_frog/lib/src/request.dart
@@ -93,7 +93,7 @@ class Request {
 
   Request._(this._request);
 
-  shelf.Request _request;
+  final shelf.Request _request;
 
   /// Connection information for the associated HTTP request.
   HttpConnectionInfo get connectionInfo {
@@ -120,16 +120,12 @@ class Request {
 
   /// Returns a [Future] containing the body as a [String].
   Future<String> body() async {
-    const requestBodyKey = 'dart_frog.request.body';
-    final bodyFromContext =
-        _request.context[requestBodyKey] as Completer<String>?;
-    if (bodyFromContext != null) return bodyFromContext.future;
+    final bodyFromContext = _bodyFutureExpando[_request];
+    if (bodyFromContext != null) return bodyFromContext;
 
     final completer = Completer<String>();
     try {
-      _request = _request.change(
-        context: {..._request.context, requestBodyKey: completer},
-      );
+      _bodyFutureExpando[_request] = completer.future;
       completer.complete(await _request.readAsString());
     } catch (error, stackTrace) {
       completer.completeError(error, stackTrace);
@@ -158,3 +154,5 @@ class Request {
     return Request._(_request.change(headers: headers, path: path, body: body));
   }
 }
+
+final _bodyFutureExpando = Expando<Future<String>>('dart_frog.request.body');
diff --git a/packages/dart_frog/pubspec.yaml b/packages/dart_frog/pubspec.yaml
@@ -1,6 +1,6 @@
 name: dart_frog
 description: A fast, minimalistic backend framework for Dart built by Very Good Ventures.
-version: 1.1.0
+version: 1.1.1-wip
 homepage: https://dartfrog.vgv.dev
 repository: https://github.com/VeryGoodOpenSource/dart_frog
 issue_tracker: https://github.com/VeryGoodOpenSource/dart_frog/issues