Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow embedded config to come from an external file #2899

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Allow embedded config to come from an external file #2899

merged 3 commits into from
Aug 18, 2023

Commits on Aug 17, 2023

  1. Allow embedded config to come from an external file 

    On MacOS we can not modify the binary after build due to hashes and
verifications. This PR allows the embedded config to be written to a
stub file (shell script) which can be used later to bootstrap the
offline collector.

This approach is a bit more complicated but will also be useful on
Windows where the repack operation invalidates the signature. We can
still use this same approach on Windows too without needing to resign
the binary.
    @scudette
    scudette committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    7e3ee24 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @scudette
    scudette committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c509b6a View commit details
    Browse the repository at this point in the history

  3. Fixed test

    @scudette
    scudette committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    7b6e235 View commit details
    Browse the repository at this point in the history