Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Allow serve url to be set without materializing #2894

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Bugfix: Allow serve url to be set without materializing #2894

merged 2 commits into from
Aug 16, 2023

Commits on Aug 16, 2023

  1. Bugfix: Allow serve url to be set without materializing 

    Some servers have locked down egress and can not materialize the tool
themselves (to calculate the tool hash). This means that the user is
not able to set an alternative serve url from these servers without
triggering a materialize (which fails)

This PR does not require the server to materialize the tool when
updating the serve url. This allows a user to manually upload a
tool (thereby calculating its hash) then change the serve url,
preserving the hash - all without the server fetching the tool from
the internet.
    @scudette
    scudette committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    fd25a83 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @scudette
    scudette committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    bc42c7f View commit details
    Browse the repository at this point in the history