fix: Always return an error or some content from LimitedReader #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contract from io.ReaderAt requires that err != nil if less than len(p) bytes are returned, and that 0 <= n <= len(p). LimitedReader currently fulfills neither requirements: - For off > self.N, n is negative. - For off + n > self.N, n is limited and thus n < len(p), but no error is returned. Add additional cases to catch these contract violations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contract from io.ReaderAt requires that err != nil if less
than len(p) bytes are returned, and that 0 <= n <= len(p).
LimitedReader currently fulfills neither requirements:
but no error is returned.
Add additional cases to catch these contract violations.