-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][GUI][CSS] Wallet Styling Refactoring (*.ui) (*.css) #926
base: master
Are you sure you want to change the base?
Conversation
src/qt/veil/forms remaining: |
If my latest change to the css selectors by .ui file works, the massive headache of removing duplicates will not be necessary. (It didn't work, but will only know after all .ui styling is applied to main.css and ordered BEFORE the pre-existing main.css styling) After which, moving any of the previously existing styling in main.css to the bottom of the file below the migrated .ui stylings should account for the overriding functionality the .css file was performing for any of the existing styling. |
….git into css_refactor_local
Fixed a qt setting misconfiguration where the send coins selection model pop-up wasnt properly applying a transparent background. |
Ready for testing after latest commit 1a320bb |
All is looking good. Light mode. |
Base work for refactoring is in this pull request, but additional dark mode is built into PR #933 |
In an attempt to make the styling more uniform and manageable, I'm going to break-out all the in-line css from the .ui files and bring them into the main.css (and eventually main-dark.css for dark mode). Also relating to styling approach established in the thread of this pull request: #907
To-Do:
Next Issue:
Fix small gap above Transactions List