Implement RingCT Staking

CMakeLists.txt

@@ -822,6 +822,7 @@ add_executable(veil
         src/veil/ringct/rpcanonwallet.h
         src/veil/ringct/stealth.cpp
         src/veil/ringct/stealth.h
+        src/veil/ringct/transactionsigcontext.h 
         src/veil/ringct/types.h
         src/veil/zerocoin/accumulatormap.cpp
         src/veil/zerocoin/accumulatormap.h

src/arith_uint256.cpp

@@ -66,7 +66,7 @@ base_uint<BITS>& base_uint<BITS>::operator*=(uint32_t b32)
 }
 
 template <unsigned int BITS>
-base_uint<BITS>& base_uint<BITS>::operator*=(const base_uint& b)
+base_uint<BITS>& base_uint<BITS>::safeMultiply(const base_uint& b, bool& overflow)
 {
     base_uint<BITS> a;
     for (int j = 0; j < WIDTH; j++) {
@@ -76,11 +76,20 @@ base_uint<BITS>& base_uint<BITS>::operator*=(const base_uint& b)
             a.pn[i + j] = n & 0xffffffff;
             carry = n >> 32;
         }
+        // j > 0 implies we hit i + j == WIDTH before i == WIDTH
+        overflow |= carry > 0 || (j > 0 && pn[j] > 0 && b.pn[WIDTH - j] > 0);
     }
     *this = a;
     return *this;
 }
 
+template <unsigned int BITS>
+base_uint<BITS>& base_uint<BITS>::operator*=(const base_uint& b)
+{
+    bool overflow = true;
+    return safeMultiply(b, overflow);
+}
+
 template <unsigned int BITS>
 base_uint<BITS>& base_uint<BITS>::operator/=(const base_uint& b)
 {
@@ -188,6 +197,7 @@ unsigned int base_uint<BITS>::bits() const
 template base_uint<256>::base_uint(const std::string&);
 template base_uint<256>& base_uint<256>::operator<<=(unsigned int);
 template base_uint<256>& base_uint<256>::operator>>=(unsigned int);
+template base_uint<256>& base_uint<256>::safeMultiply(const base_uint<256>& b, bool& overflow);
 template base_uint<256>& base_uint<256>::operator*=(uint32_t b32);
 template base_uint<256>& base_uint<256>::operator*=(const base_uint<256>& b);
 template base_uint<256>& base_uint<256>::operator/=(const base_uint<256>& b);
@@ -203,6 +213,7 @@ template unsigned int base_uint<256>::bits() const;
 template base_uint<512>::base_uint(const std::string&);
 template base_uint<512>& base_uint<512>::operator<<=(unsigned int);
 template base_uint<512>& base_uint<512>::operator>>=(unsigned int);
+template base_uint<512>& base_uint<512>::safeMultiply(const base_uint<512>& b, bool& overflow);
 template base_uint<512>& base_uint<512>::operator*=(uint32_t b32);
 template base_uint<512>& base_uint<512>::operator*=(const base_uint<512>& b);
 template base_uint<512>& base_uint<512>::operator/=(const base_uint<512>& b);

src/arith_uint256.h

@@ -166,6 +166,7 @@ class base_uint
         return *this;
     }
 
+    base_uint& safeMultiply(const base_uint& b, bool& overflow);
     base_uint& operator*=(uint32_t b32);
     base_uint& operator*=(const base_uint& b);
     base_uint& operator/=(const base_uint& b);

src/chainparams.cpp

@@ -759,7 +759,7 @@ class CRegTestParams : public CChainParams {
         // ProgPow, RandomX, Sha256d
         consensus.nProgPowTargetSpacing = 172;
         consensus.nRandomXTargetSpacing = 600;
-        consensus.nSha256DTargetSpacing = 1200;
+        consensus.nSha256DTargetSpacing = 120;
 
         consensus.nDgwPastBlocks = 60; // number of blocks to average in Dark Gravity Wave
         consensus.nDgwPastBlocks_old = 60; // number of blocks to average in Dark Gravity Wave
@@ -879,9 +879,10 @@ class CRegTestParams : public CChainParams {
         /** RingCT/Stealth **/
         nDefaultRingSize = 11;
 
-        nHeightLightZerocoin = 500;
+        nHeightLightZerocoin = 110;
         nZerocoinRequiredStakeDepthV2 = 10; //The required confirmations for a zerocoin to be stakable
         nHeightEnforceBlacklist = 0;
+        nHeightRingCTStaking = 300;
 
         nMaxHeaderRequestWithoutPoW = 50;
         nPreferredMintsPerBlock = 70; //Miner will not include more than this many mints per block

src/chainparams.h

@@ -147,6 +147,8 @@ class CChainParams
     int HeightLightZerocoin() const { return nHeightLightZerocoin; }
     int HeightEnforceBlacklist() const { return nHeightEnforceBlacklist; }
     int HeightProgPowDAGSizeReduction() const { return nHeightProgPowDAGSizeReduction; }
+    int HeightRingCTStaking() const { return nHeightRingCTStaking; }
+    int RingCT_RequiredStakeDepth() const { return nZerocoinRequiredStakeDepthV2; }
 
     uint32_t PowUpdateTimestamp() const { return nPowUpdateTimestamp; }
     uint64_t KIforkTimestamp() const { return nTimeKIfork; }
@@ -236,6 +238,7 @@ class CChainParams
     int nHeightLightZerocoin;
     int nHeightEnforceBlacklist;
     int nHeightProgPowDAGSizeReduction;
+    int nHeightRingCTStaking = 50000000;
 
     //Settings that are not chain critical, but should not be edited unless the person changing understands the consequence
     int nMaxHeaderRequestWithoutPoW;

src/consensus/tx_verify.cpp

@@ -563,7 +563,7 @@ bool Consensus::CheckTxInputs(const CTransaction& tx, CValidationState& state, c
     } else {
         // Return stake reward in nTxFee
         txfee = nPlainValueOut - nValueIn;
-        if (nCt > 0 || nRingCT > 0) { // counters track both outputs and inputs
+        if (nCt > 0) { // counters track both outputs and inputs
             return state.DoS(100, error("ConnectBlock(): non-standard elements in coinstake"),
                              REJECT_INVALID, "bad-coinstake-outputs");
         }