Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix when points are np.ndarray (without numpy dependency #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bjotori
Copy link

@Bjotori Bjotori commented Dec 12, 2022

fix sort with np.ndarray
fix warning 'np.bool_' scalars to be interpreted as an index

fix sort with np.ndarray + fix warning 'np.bool_' scalars to be interpreted as an index
@gitkeniwo
Copy link

I don't think this solution works as the ndarray sorting is still glitchy

File ~/kd_tree.py:48, in KDTree.__init__.<locals>.make(points, i)
     46     i = (i + 1) % dim
     47     m = len(points) >> 1
...
---> 45     points.sort(axis=i) # np.ndarray
     46 i = (i + 1) % dim
     47 m = len(points) >> 1

AxisError: axis 2 is out of bounds for array of dimension 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants