first take on static dispatch mapping. #238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markos
reviewed
Apr 4, 2024
markos
reviewed
Apr 4, 2024
src/dispatcher.c
Outdated
| CONNECT_DISPATCH_2(hs_error_t, hs_scan, const hs_database_t *db, const char *data, | ||
| unsigned length, unsigned flags, hs_scratch_t *scratch, | ||
| match_event_handler onEvent, void *userCtx); | ||
| CONNECT_ARGS_3(hs_error_t, hs_scan, db, data, length, flags, scratch, onEvent, userCtx); |
There was a problem hiding this comment.
it would be great if those macros could be unified in one. Also, can you try to remove those pragmas and see if it causes a problem?
isildur-g
force-pushed
the
dispatcher-static
branch
from
8e29f66 to
6e306a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
call to one of the dispatched functions, we determine the correct target and replace a static func ptr to point to the correct target. on subsequent calls
we directly call the target. It's a bit messy and
while it eliminates the branching and ifunc indirection at runtime, it still involves a second function call and copying of a stack frame etc. The macros are
a fair bit uglier now but one needs to be able to
specify both the full arg list of a given function, as well as specify only the names of the args, to
macro out the invocation of the passthrough call.
The extra router function could be merged into the resolve function, but i wanted to leave that more
or less untouched for the first review.