Skip to content

Conversation

@emesare
Copy link
Member

@emesare emesare commented Dec 5, 2025

The partial register id is the "main" id so we return that, whereas the full register id is not.

@bdash did you have any more thoughts surrounding the usage of this API?

@emesare emesare self-assigned this Dec 5, 2025
@emesare emesare added the Component: Rust API Issue needs changes to the Rust API label Dec 5, 2025
@bdash
Copy link
Contributor

bdash commented Dec 8, 2025

I'm not sure about this API. It does not seem obvious to a client what id will return for a partial register. Maybe a doc comment fixes that, or perhaps there's a clearer name.

I'm not even 100% sure whether get_ssa_register_uses and friends are doing the right thing with how they handle partial registers at the moment.

@emesare
Copy link
Member Author

emesare commented Dec 10, 2025

I'm not even 100% sure whether get_ssa_register_uses and friends are doing the right thing with how they handle partial registers at the moment.

Yea it seems that it was never intended to be queried with a partial register, I fixed up the LowLevelILSSARegisterKind to make it so that partial register will not be able to be passed to any of those api's. I also added some more doc comments to hopefully try and explain what Full and Partial ssa register kinds are.

11cc166

The partial register id is the "main" id so we return that, whereas the full register id is not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Rust API Issue needs changes to the Rust API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants