arm64: Lift FCVTZS Wd,Dn,#n to LLIL #6280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lift
FCVTZS Wd,Dn,#nto LLIL as an intrinsic.The intrinsic is made up in the sense that I could not find an intrinsic corresponding to this instruction variant in Arm Neon Intrinsics Reference nor in
arm_neon.hshipping with Xcode's clang. There is precedent for such made up intrinsics: The unsigned version of this,FCVTZU Wd,Dn,#n, was added as part of c3040ec.I've added two tests to
arm64test.pythat pass (after disabling thetests_tbltest group that's currently failing for reasons unrelated to this PR). Also tested that it resolves the unimplemented instruction error with an in-the-wild binary that makes use of this instruction variant (not sharable).