Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forge + Fabric Opaque Particles for Shader Compat #4525

Open
wants to merge 10 commits into
base: 1.20.x
Choose a base branch
from

Conversation

blagdorfinguy
Copy link

When a shader pack uses GLSL deferred rendering, particles with transparency are not rendered correctly.

This addition to the config file will change the rendering method when opaqueParticles is set to true in the config, so particles render opaquely (albeit not quite as pretty as they render as is, with shaders they would not have rendered at all, so I feel this change is beneficial but not perfect)

@blagdorfinguy
Copy link
Author

Should be resolved

@williewillus
Copy link
Member

did you push your changes? The comments I left still seem relevant on the latest version of your PR

@blagdorfinguy
Copy link
Author

Sorry, baby's first git bash :)

@blagdorfinguy
Copy link
Author

blagdorfinguy commented Jan 10, 2024

Supplemental info- intended to fix #4297 , btw- my comment there is similarly relevant; disabling botania's shaders decrease aesthetic detail, but increase compatibility with certain shaders. This fork is intended to extend that concept to include OpenGL deferred shaders as well

image
For review - if someone is taking a look and doesn't want to build just to see the effects of this PR this screenshot shows a full range of effects with shaders on/off and the new setting on/off. When the setting is off, there is no change to the "look" of the mod, and the new setting is disabled by default, with a relevant comment in the config to indicate visuals are impacted if shaders are not installed or used- 'for compatibility issues only'

Note: This screenshot was made while the config settings for shader compat and particle compat were combined, but in the current build they are separate options, as noted above

@TheRealWormbo
Copy link
Collaborator

There will probably be a bunch of shader-/rendering-related changes in the 1.21 port. This PR seems worth revisiting as part of that.

@artemisSystem artemisSystem added the after-1.21-port This will not be fixed/implemented before the port to 1.21 label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
after-1.21-port This will not be fixed/implemented before the port to 1.21 investigate
Development

Successfully merging this pull request may close these issues.

4 participants