Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gaia arena check to api #4299

Open
wants to merge 3 commits into
base: 1.19.x
Choose a base branch
from

Conversation

justliliandev
Copy link

This PR adds 2 methods to the api to check if something is currently inside a gaia arena

@williewillus
Copy link
Member

Thanks. Can you do the following:

  1. Check the lint/format errors
  2. Instead of duplicating the logic, change the Botania Doppleganger class to call the API method instead.

@justliliandev
Copy link
Author

I wouldn't recommend doing that, as the gaia logic would be as follows:

  1. Gaia tick
  2. Gaia searches for close Players
  3. API check if player is inside arena by looking for nearby gaia guardian entities
  4. API check if the player is inside the arena of that guardian

this would result in the guardian looking essentially for itself to disable players.
I've changed the api to use the arena AABB which is used in the player lookup to do the arena check, as this is what is used for looking for nearby players and disabling their flight/sleeping/removing effects

@justliliandev justliliandev reopened this Jun 7, 2023
@TheRealWormbo TheRealWormbo added the after-1.21-port This will not be fixed/implemented before the port to 1.21 label Jul 13, 2024
@TheRealWormbo
Copy link
Collaborator

We should probably incorporate this change in the 1.21 port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
after-1.21-port This will not be fixed/implemented before the port to 1.21
Development

Successfully merging this pull request may close these issues.

3 participants