General24 #102
Merged
General24 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs, made anchorlinks work better, made a setting tweaker plugin, renamed general themes, tried to finish the new theme
Uular
requested changes
Nov 21, 2024
vj_cms/cms_plugins.py
Outdated
| from datetime import datetime | ||
|
|
||
| client = VJClient(settings.VJ_API_URL) | ||
|
|
||
| @plugin_pool.register_plugin | ||
| class MobileSpeechbubble(CMSPluginBase): |
There was a problem hiding this comment.
Plugin names should end with Plugin
|
|
||
| def render(self, context, instance, placeholder): | ||
| context = super().render(context, instance, placeholder) | ||
| return context |
vj_cms/cms_plugins.py
Outdated
| context = super().render(context, instance, placeholder) | ||
| return context | ||
| @plugin_pool.register_plugin | ||
| class TweakSettings(CMSPluginBase): |
There was a problem hiding this comment.
Plugin names should end with Plugin
| @plugin_pool.register_plugin | ||
| class TweakSettings(CMSPluginBase): | ||
| name = 'Tweak Settings' | ||
| model = TweakSettings |
There was a problem hiding this comment.
Model name clashes with the plugin class name – one reason to name the plugin TweakSettingsPlugin
vj_cms/cms_plugins.py
Outdated
| return context | ||
|
|
||
| @plugin_pool.register_plugin | ||
| class AnchorLink(CMSPluginBase): |
There was a problem hiding this comment.
Plugin names should end with Plugin
| @plugin_pool.register_plugin | ||
| class AnchorLink(CMSPluginBase): | ||
| name = 'Anchor link' | ||
| model = AnchorLink |
There was a problem hiding this comment.
Model name clashes with the plugin class name – one reason to name the plugin AnchorLinkPlugin
vj_cms/cms_plugins.py
Outdated
| return context | ||
|
|
||
| @plugin_pool.register_plugin | ||
| class PriorityMessage(CMSPluginBase): |
There was a problem hiding this comment.
Plugin names should end with Plugin
|
New generic theme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.