Clarify what kind of variable we're talking about #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sort of. It's actually a make variable, so you can also specify it like The |
|
How does that sound? |
README.md
Outdated
| @@ -66,7 +66,9 @@ targets to build Proton: | |||
| `make install` - This will install Proton into your user's Steam directory. | |||
| You may need to restart the Steam client to see it. The tool's name in the | |||
| Steam client will be based on the currently checked out branch of Proton. You | |||
| can override this name using the `build_name` variable. | |||
| can override this name using the `build_name` make variable, which can be set | |||
| via an evironment variable or an argument to the make command | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Thank you, I'll fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it clearer that you should set an environment variable and not something else.