Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ack frame #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: ack frame #352

wants to merge 1 commit into from

Conversation

hax0r31337
Copy link

There was a typo for checking against the size of latest_received_pkt_num.
As the packet mask is 0b10010000, nFrameType & 0x40 will always be zero.
I changed the mask to 0x10 according to the format documentation.

@hax0r31337
Copy link
Author

also got another question, why bother use varint on select lane frame if the max acceptable lane number is 255

@zpostfacto
Copy link
Contributor

Hey, this looks like really great stuff!

I'm swamped right now, but thanks so much for digging into the wire encoding. It looks like you've found a good bug, and are asking good questions. I'll try to get back to you soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants