VSU: Improve accuracy #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a number of changes to the Virtual Boy emulator to make it more accurate to how the original hardware behaves. These changes are based on my own testing of the hardware.
The most significant change is that writes to wave channels are ignored if any sound is playing. All VGM files created by Furnace before version 0.6.8 rely on this being emulated incorrectly.
Other behaviours are relied on by certain games, e.g. the homebrew game Hyper Fighting constantly writes to S5EV1 to keep the noise channel at a standard value, so that it can be modulated for sample playback.
With that in mind, maybe you'd want to keep the original version as a separate core? Does this project prefer accuracy or compatibility with existing files?
General:
Noise:
Envelopes:
Sweep/modulation: