fixup: remove mangling in extensions/ (introduced in 1.80) #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes the reproducibility issue mentioned in microsoft/vscode#189124
|
Is this still an issue after their fix? |
|
Probably isn't. I haven't checked but AFAIK you want to remove mangling anyway to make hacking the UI possible. I myself don't use UI-changing extensions but have noticed that the mangler often OOMed on our (openSUSE) servers leading to build failures. |
|
The changes have been merged in #2090. We will test it in the Insiders version to see if there is no issues before moving it to the stable version. |
|
@brjsp Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the reproducibility issue mentioned in microsoft/vscode#189124