Skip to content

Conversation

@Ughuuu
Copy link
Collaborator

@Ughuuu Ughuuu commented Nov 19, 2025

  • Use eslint for formatting of frontend
  • Add linting on ci/cd for backend
  • Add docker publish to ghcr for frontend and backend
  • Create CHANGELOG, CONTRIBUTING and ARCHITECTURE docs. Update README.

@fire fire changed the title add build and push docker to ghcr for uro Add build and push docker to ghcr for uro Nov 19, 2025
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we merge can you squash to one commit?

@Ughuuu Ughuuu force-pushed the build-and-deploy-docker-to-ghcr branch from eaaa8e3 to 4fc0bec Compare November 19, 2025 19:57
@fire
Copy link
Member

fire commented Nov 19, 2025

Can you try a more readable github commit message?

Like:

Add build and push docker to ghcr for uro

  • only do frontend build on master branch
  • update gitignore
  • push only on main
  • Add arm host on arm build
  • disable cache
  • build and push frontend
  • disable job cancelling
  • separate in 2 jobs
  • Update to only build for PR
  • Push uro-frontend
  • Build both arm64 and amd64

Maybe a bit more summarized.

@Ughuuu Ughuuu force-pushed the build-and-deploy-docker-to-ghcr branch from aa1c741 to c62611a Compare November 22, 2025 13:10
update gitignore

only do frontend build on master branch

push only on main

remove extra }

use arm host on arm build

add comment

try with +JPperf true

disable cache

build and push frontend

remove cached stuff

disable job cancelling

upd

use separate step for arch

separate in 2 jobs

fix for arm64 to install openssl and ca-certs

fix warnings

upd to only build for PR

fix docker warnings

also push uro-frontend

build both arm64 and amd64

only push on master

test pushing

fix lower case

Add also linting job for frontend.

Update lint.yml
@Ughuuu Ughuuu force-pushed the build-and-deploy-docker-to-ghcr branch from c62611a to a60a76f Compare November 22, 2025 13:10
@Ughuuu Ughuuu requested a review from fire November 22, 2025 13:14
@fire
Copy link
Member

fire commented Nov 22, 2025

The credo lint can be turned into an ignore so it passes but still outputs. The code doesn't have compile errors as far as I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants