Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): Refactor RPC server and fix tests #36

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

binarybaron
Copy link

@binarybaron binarybaron commented Aug 27, 2024

@binarybaron binarybaron force-pushed the fix-rpc-tests branch 2 times, most recently from ed2e0d8 to 13d8364 Compare August 27, 2024 18:52
@binarybaron binarybaron changed the title fix(cli): Remove test for removed log_reference_id feature refactorcli): Use Request trait for RPC server, fix tests Aug 27, 2024
@binarybaron binarybaron changed the title refactorcli): Use Request trait for RPC server, fix tests refactorcli): Refactor RPC server and fix tests Aug 27, 2024
@binarybaron binarybaron changed the title refactorcli): Refactor RPC server and fix tests refactor(cli): Refactor RPC server and fix tests Aug 27, 2024
@Einliterflasche
Copy link

looks very solid so far. at least one test failing (with the regex error) can be fixed by bumping tracing subscriber to 0.3 in monero-harness

@binarybaron binarybaron force-pushed the fix-rpc-tests branch 2 times, most recently from 644a6a9 to 2114d2e Compare August 28, 2024 10:13
- Use the Request trait introduced in #10 for the RPC server
- Delegate deserialization of RPC server method parameters to serde by using structs like BuyXmrArgs
- Remove `get_raw_states` RPC server method because it's not used
- Fix RPC server tests including removing test for the "log reference id" feature which was removed as part of #10
- Rename GetCurrentSwap struct to GetCurrentSwapArgs
@binarybaron binarybaron merged commit aac366f into master Aug 28, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants