refactor(cli): Refactor RPC server and fix tests #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarybaron
force-pushed
the
fix-rpc-tests
branch
2 times, most recently
from
ed2e0d8 to
13d8364
Compare
binarybaron
changed the title
binarybaron
changed the title
binarybaron
force-pushed
the
fix-rpc-tests
branch
from
f7599de to
b6e54c7
Compare
binarybaron
changed the title
binarybaron
force-pushed
the
fix-rpc-tests
branch
from
b6e54c7 to
b7e5906
Compare
|
looks very solid so far. at least one test failing (with the regex error) can be fixed by bumping tracing subscriber to 0.3 in monero-harness |
binarybaron
force-pushed
the
fix-rpc-tests
branch
2 times, most recently
from
644a6a9 to
2114d2e
Compare
- Use the Request trait introduced in #10 for the RPC server - Delegate deserialization of RPC server method parameters to serde by using structs like BuyXmrArgs - Remove `get_raw_states` RPC server method because it's not used - Fix RPC server tests including removing test for the "log reference id" feature which was removed as part of #10 - Rename GetCurrentSwap struct to GetCurrentSwapArgs
binarybaron
force-pushed
the
fix-rpc-tests
branch
from
2114d2e to
66d1e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_raw_statesRPC server method because it's not used