Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asb): Retry publishing Bitcoin redeem transaction #221

Merged
merged 8 commits into from
Dec 4, 2024

Conversation

binarybaron
Copy link

No description provided.

@binarybaron binarybaron force-pushed the asb/retry-publish-btc-tx-redeem branch from ac47bdc to 8899b07 Compare December 3, 2024 21:19
Copy link

@Einliterflasche Einliterflasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few comments, untested

swap/src/protocol/alice/swap.rs Outdated Show resolved Hide resolved
swap/src/protocol/alice/swap.rs Outdated Show resolved Hide resolved
swap/src/protocol/alice/swap.rs Outdated Show resolved Hide resolved
@delta1
Copy link
Collaborator

delta1 commented Dec 4, 2024

re-running failed/cancelled CI jobs

@binarybaron binarybaron force-pushed the asb/retry-publish-btc-tx-redeem branch from f644233 to 8f2b4d4 Compare December 4, 2024 12:03
…tify to be able to log how long we'll wait until next retry
@binarybaron binarybaron force-pushed the asb/retry-publish-btc-tx-redeem branch from 8f2b4d4 to 308bc3c Compare December 4, 2024 12:04
@binarybaron
Copy link
Author

We should really have tests to reliably test the retry machanisms...

@binarybaron binarybaron force-pushed the asb/retry-publish-btc-tx-redeem branch from 3225760 to f00f550 Compare December 4, 2024 12:56
@binarybaron binarybaron merged commit c5894ea into master Dec 4, 2024
25 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants