forked from comit-network/xmr-btc-swap
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(asb): Retry publishing Bitcoin redeem transaction #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarybaron
force-pushed
the
asb/retry-publish-btc-tx-redeem
branch
from
December 3, 2024 21:19
ac47bdc
to
8899b07
Compare
Einliterflasche
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
delta1
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few comments, untested
re-running failed/cancelled CI jobs |
…ng Bitcoin, add some TODOs
binarybaron
force-pushed
the
asb/retry-publish-btc-tx-redeem
branch
from
December 4, 2024 12:03
f644233
to
8f2b4d4
Compare
…tify to be able to log how long we'll wait until next retry
binarybaron
force-pushed
the
asb/retry-publish-btc-tx-redeem
branch
from
December 4, 2024 12:04
8f2b4d4
to
308bc3c
Compare
We should really have tests to reliably test the retry machanisms... |
binarybaron
force-pushed
the
asb/retry-publish-btc-tx-redeem
branch
from
December 4, 2024 12:56
3225760
to
f00f550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.